💚 Build Succeeded

• Buildkite Build
• Commit: 225a119

Instead of having the various step-builders iterate over logstash's
ci/logstash_releases.json@main and programmatically determine which to run, I would prefer to have the canonical source be a branch-specific config file with the list of things to run if they can be resolved. This inversion keeps the mapping of what Logstashes are supported by the plugin local to the plugin's source which cannot drift.

For example, on any 8.${x} branch, we always want to test PR's against the upcoming, current, and previous supported 8.x versions, but we don't care about the plugin's ability to run against an unrelesaed possibly-breaking Logstash 9, so the config file would look like:

.buildkite/[email protected]

releases:
 - 8.current
 - 8.previous
snapshots:
 - 8.future
 - 8.next
 - 8.current
 - 8.previous

And on the main branch (9.x) before the 9.0 FF and 8.last FF, we need to only test against the snapshots for unreleased Logstash 9 and Logstash 8.future, but since we tolerate null-derefs, we can preemptively add everything so that it will just work once we start getting 9.x snapshots and releases:

.buildkite/pull-request-matrix.yaml@main (9.x)

releases:
 - 9.current # null-deref-ok
 - 9.previous # null-deref-ok
snapshots:
 - main
 - 9.future # null-deref-ok
 - 9.next # null-deref-ok
 - 9.current # null-deref-ok
 - 9.previous # null-deref-ok
 - 8.future

The only really interesting but is that once the 8.last branch has been cut and 8.future disappears, we will need to remap our 8.future snapshot reference to 8.next.

.buildkite/pull-request-matrix.yaml@main (9.x)

 releases:
  - 9.current # null-deref-ok
  - 9.previous # null-deref-ok
 snapshots:
  - main
  - 9.future # null-deref-ok
  - 9.current # null-deref-ok
  - 9.previous # null-deref-ok
- - 8.future
+ - 8.next

And then once 8.last has a release we will need to add it to the matrix and swap 8.next for 8.current:

.buildkite/pull-request-matrix.yaml@main (9.x)

 releases:
  - 9.current # null-deref-ok
  - 9.previous # null-deref-ok
+ - 8.current
 snapshots:
  - main
  - 9.future # null-deref-ok
  - 9.current # null-deref-ok
  - 9.previous # null-deref-ok
- - 9.next
+ - 8.current

💚 Build Succeeded

• Buildkite Build
• Commit: 2f569b0

History

• 💚 Build #447 succeeded 8dd34e3

cc @mashhurs

Thanks for linking the builds based on these.

Yup, thank you!
As stated in the description, we cannot run scheduled builds/E2E-tests (confirmed them on my local but BK env vars cannot be involved). The only manual way is to land this change and kick off CIs on BK ui with main branch. I will merge and kick them off, if there is anything strange, I will follow up.